Re: [PATCH V2] staging:bcm: Code cleanup for InterfaceDld.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2013 at 10:38:47PM +0530, Gokulnath A wrote:
> As per the TODO,
> 
> 1. Removed the developer debug BCM_DEBUG_PRINT() messages.
> 2. Fixed all the errors found by checkpatch.pl script.
> 3. Fixed all the line over 80 characters warning
>    found by checkpatch.pl script.

As you say you are doing 3 things, why is this all in one patch?  Please
only do one-thing-per-patch.  Here you could have at least 3 patches in
a series, please do that.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux