On Mon, Dec 16, 2013 at 11:34:05AM +0000, Russell King wrote: > Trying to build a modular imx-drm results in a number of missing symbol > exports, caused by the recent changes to this driver. Add the necessary > exports, and the missing MODULE_LICENSE() tag. Since commit 9c74360 (staging: imx-drm: Fix modular build of DRM_IMX_IPUV3) is in place now, I'm not sure if we still need this patch. Shawn > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > --- > drivers/staging/imx-drm/ipuv3-plane.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/imx-drm/ipuv3-plane.c b/drivers/staging/imx-drm/ipuv3-plane.c > index d97454a0dffd..745fc8171df0 100644 > --- a/drivers/staging/imx-drm/ipuv3-plane.c > +++ b/drivers/staging/imx-drm/ipuv3-plane.c > @@ -40,6 +40,7 @@ int ipu_plane_irq(struct ipu_plane *ipu_plane) > return ipu_idmac_channel_irq(ipu_plane->ipu, ipu_plane->ipu_ch, > IPU_IRQ_EOF); > } > +EXPORT_SYMBOL_GPL(ipu_plane_irq); > > static int calc_vref(struct drm_display_mode *mode) > { > @@ -81,6 +82,7 @@ int ipu_plane_set_base(struct ipu_plane *ipu_plane, struct drm_framebuffer *fb, > > return 0; > } > +EXPORT_SYMBOL_GPL(ipu_plane_set_base); > > int ipu_plane_mode_set(struct ipu_plane *ipu_plane, struct drm_crtc *crtc, > struct drm_display_mode *mode, > @@ -184,6 +186,7 @@ int ipu_plane_mode_set(struct ipu_plane *ipu_plane, struct drm_crtc *crtc, > > return 0; > } > +EXPORT_SYMBOL_GPL(ipu_plane_mode_set); > > void ipu_plane_put_resources(struct ipu_plane *ipu_plane) > { > @@ -194,6 +197,7 @@ void ipu_plane_put_resources(struct ipu_plane *ipu_plane) > if (!IS_ERR_OR_NULL(ipu_plane->ipu_ch)) > ipu_idmac_put(ipu_plane->ipu_ch); > } > +EXPORT_SYMBOL_GPL(ipu_plane_put_resources); > > int ipu_plane_get_resources(struct ipu_plane *ipu_plane) > { > @@ -228,6 +232,7 @@ int ipu_plane_get_resources(struct ipu_plane *ipu_plane) > > return ret; > } > +EXPORT_SYMBOL_GPL(ipu_plane_get_resources); > > void ipu_plane_enable(struct ipu_plane *ipu_plane) > { > @@ -238,6 +243,7 @@ void ipu_plane_enable(struct ipu_plane *ipu_plane) > > ipu_plane->enabled = true; > } > +EXPORT_SYMBOL_GPL(ipu_plane_enable); > > void ipu_plane_disable(struct ipu_plane *ipu_plane) > { > @@ -250,6 +256,7 @@ void ipu_plane_disable(struct ipu_plane *ipu_plane) > ipu_idmac_disable_channel(ipu_plane->ipu_ch); > ipu_dmfc_disable_channel(ipu_plane->dmfc); > } > +EXPORT_SYMBOL_GPL(ipu_plane_disable); > > static void ipu_plane_dpms(struct ipu_plane *ipu_plane, int mode) > { > @@ -373,3 +380,6 @@ struct ipu_plane *ipu_plane_init(struct drm_device *dev, struct ipu_soc *ipu, > > return ipu_plane; > } > +EXPORT_SYMBOL_GPL(ipu_plane_init); > + > +MODULE_LICENSE("GPL"); > -- > 1.7.4.4 > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel