On Sat, Dec 14, 2013 at 4:41 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Sat, Dec 14, 2013 at 01:05:29AM +0530, Gokulnath A wrote:
>> fixed all the errors found by checkpatch.pl
>>
>
> This is not very useful. The subjects of this patch series could be
> improved as well.
i will take care of it, in the next set of patches.
>
>> Signed-off-by: Gokulnath A <Gokulnath.Avanashilingam@xxxxxxxxxxxx>
>> ---
>> drivers/staging/bcm/InterfaceDld.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/bcm/InterfaceDld.c b/drivers/staging/bcm/InterfaceDld.c
>> index 463bdee..a8d0063 100644
>> --- a/drivers/staging/bcm/InterfaceDld.c
>> +++ b/drivers/staging/bcm/InterfaceDld.c
>> @@ -115,7 +115,7 @@ int InterfaceFileReadbackFromChip(PVOID arg, struct file *flp, unsigned int on_c
>> while (len) {
>> if (*(unsigned int *)&buff_readback[len] != *(unsigned int *)&buff[len]) {
>> BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "Firmware Download is not proper %d", fw_down);
>> - BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "Val from Binary %x, Val From Read Back %x ", *(unsigned int *)&buff[len], *(unsigned int*)&buff_readback[len]);
>> + BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "Val from Binary %x, Val From Read Back %x ", *(unsigned int *)&buff[len], *(unsigned int *)&buff_readback[len]);
>> BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "len =%x!!!", len);
>
> Really this whole block of text is garbage. I'm not sure it makes sense
> to worry about a tiny missing space when the whole block is so rubbish.
> Fixing it up properly is a bit difficult, but it's really what we need.
i will cleanup the code, and send the patch.
Thanks for the review comments.
>
> regards,
> dan carpenter
>
>
Thanks and Regards
Gokulnath A
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
