On Mon, 2013-12-09 at 12:13 +0200, Ivaylo DImitrov wrote:
> From: Ivaylo Dimitrov <freemangordon@xxxxxx>
>
> Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't
> need to be exported. It can also be made way simpler by using sscanf.
Hi Ivaylo.
Trivial notes:
The function name change in dbcdc.c from
uuid_uuid_from_string to dcd_uuid_from_string
seems unnecessary.
If you are going to change the name, please
also reindent the multi-line statements to the
open parenthesis as the rest of the file has
that style.
> diff --git a/drivers/staging/tidspbridge/rmgr/dbdcd.c b/drivers/staging/tidspbridge/rmgr/dbdcd.c
[]
> @@ -1001,7 +1042,7 @@ static int get_attrs_from_buf(char *psz_buf, u32 ul_buf_size,
> token = strsep(&psz_cur, seps);
>
> /* dsp_uuid ui_node_id */
> - uuid_uuid_from_string(token,
> + dcd_uuid_from_string(token,
> &gen_obj->obj_data.node_obj.ndb_props.
> ui_node_id);
> token = strsep(&psz_cur, seps);
The 2nd and 3rd lines of dcd_uuid_from_string
should be moved 1 left.
> @@ -1400,7 +1441,7 @@ static int get_dep_lib_info(struct dcd_manager *hdcd_mgr,
> break;
> } else {
> /* Retrieve UUID string. */
> - uuid_uuid_from_string(token,
> + dcd_uuid_from_string(token,
> &(dep_lib_uuids
> [dep_libs]));
> /* Is this library persistent? */
here too.
It also appears as if these could set status
to the from_string return value and error-out
when non-zero.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
