On Fri, Dec 06, 2013 at 09:35:03PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang <gamerh2o@xxxxxxxxx> > --- > drivers/staging/et131x/et131x.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c > index b6ce68e..3e34c2e 100644 > --- a/drivers/staging/et131x/et131x.c > +++ b/drivers/staging/et131x/et131x.c > @@ -2505,8 +2505,12 @@ static void nic_return_rfd(struct et131x_adapter *adapter, struct rfd *rfd) > * need to clean up OOB data > */ > if (buff_index < rx_local->fbr[ring_index]->num_entries) { > + u32 free_buff_ring; > u32 __iomem *offset; > struct fbr_desc *next; > + struct fbr_lookup *fbr; > + > + fbr = rx_local->fbr[ring_index]; This can be written as one line instead of three. The rest of the patch is good. Cheers, Mark _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel