On Thu, Dec 5, 2013 at 11:43 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote: >> On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: >> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro >> > is not preferred. >> > >> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> >> > >> >> I think you misunderstood the checkpatch.pl warning, it tells you what >> to do, not what not to do. >> >> WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id >> >> This means use DEFINE_PCI_DEVICE_TABLE to replace struct >> pci_device_id, not reverse. > > No, checkpatch is wrong, and is being fixed, this patch is correct. Oh, I didn't notice the recent checkpatch update, sorry for the noise. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
