I orignally posted this series on 07/24/2013. At that time Ian Abbott had some comments on it. I finally got around to addressing them. This series cleans up the interrupt support and private data usage. It also does a bit of cleanup to clarify the driver. H Hartley Sweeten (13): staging: comedi: pcmuio: fix interrupt requests staging: comedi: pcmuio: spinlock protect pcmuio_{write,read}() staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt() staging: comedi: pcmuio: remove 'asic' member from subdevice private data staging: comedi: pcmuio: remove subdevice private data staging: comedi: pcmuio: fix pcmuio_dio_insn_bits() staging: comedi: pcmuio: remove unnecessary mask of triggered channels staging: comedi: pcmuio: add inline helpers to get the 'iobase', 'asic', and 'port' staging: comedi: pcmuio: document the spinlock_t variables staging: comedi: pcmuio: fix types of some private data variables staging: comedi: pcmuio: remove unneeded include staging: comedi: pcmuio: tidy up pcmuio_attach() staging: comedi: pcmuio: tidy up pcmuio_start_intr() drivers/staging/comedi/drivers/pcmuio.c | 428 ++++++++++++++++---------------- 1 file changed, 213 insertions(+), 215 deletions(-) -- 1.8.4.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel