Re: [PATCH v5 1/7] staging: et131x: make some tweaks to reduce split lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 4, 2013 at 3:09 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Dec 04, 2013 at 01:51:41PM +0800, ZHAO Gang wrote:
>> On Wed, Dec 4, 2013 at 12:38 AM, Greg Kroah-Hartman
>> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> > On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote:
>> >> 1. As TODO list suggested, do this sort of things to reduce split lines:
>> >>       struct fbr_lookup *fbr;
>> >>       fbr = rx_local->fbr[id];
>> >>       Then replace all the instances of "rx_local->fbr[id]" with fbr.
>> >>
>> >> 2. Some code style changes
>> >>
>> >> Signed-off-by: ZHAO Gang <gamerh2o@xxxxxxxxx>
>> >
>> > This series adds a build warning in the driver, so I can't apply it.
>> >
>> > And your other series is a mess, I don't know what's up with it, so I'm
>> > dropping both of these.  Please fix these up and resend them.
>> >
>>
>> The build warning is caused by "[PATCH v5 6/7] staging: et131x: remove
>> spinlock adapter->lock", I have resent it. Actually the warning is
>> fixed in the second patch set in patch "[PATCH v2 3/4] staging:
>> et131x: fix build warning", but it's better to not even generate the
>> warning, so I also resent that patch.
>>
>> Now it should be build clean. The second patch set requires the first patch set.
>>
>> All this is because I forgot to build test the first patch set, I will
>> be carefully next time.
>
> Please resend all of your outstanding patches, as I do not have any of
> them around anymore.
>

OK, I will resend all previously sent patches.

> greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux