This patch set is based on previously sent v5 of seven patches for et131x. The v2 version does all changes Dan suggested, except that I think combine two kmalloc to one is a good(at least not so bad) idea, it simplify error path in et131x_rx_dma_memory_alloc, and simplify et131x_rx_dma_memory_free: they only need to call one kfree instead of two, it reduces the lines of code. ZHAO Gang (4): staging: et131x: simplify rx dma code staging: et131x: simplify tx dma code staging: et131x: fix build warning staging: et131x: some code style change drivers/staging/et131x/et131x.c | 290 +++++++++++----------------------------- 1 file changed, 81 insertions(+), 209 deletions(-) -- 1.8.3.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel