On 2013-11-26 23:41, H Hartley Sweeten wrote:
There are a lot of debugging messages in the comedi drivers that are just added noise. Some of them messages are worth keeping but they should be converted to the appropriate dev_{level} format. This series is a first pass at cleaning this up. H Hartley Sweeten (60): staging: comedi: pcmmio.c: remove kcalloc() failure message staging: comedi: adv_pci1710: convert some printk's to dev_dbg() staging: comedi: dmm32at: remove final attach noise and fix return value staging: comedi: pcl812: convert some printk's to dev_dbg() staging: comedi: pcl816: convert some printk's to dev_dbg() staging: comedi: pcl818: convert some printk's to dev_dbg() staging: comedi: adq12b: remove commented out debug message staging: comedi: c6xdigio: remove commented out subdevice code staging: comedi: c6xdigio: remove commented out function trace messages staging: comedi: cb_pcimdas: remove commented out irq init code staging: comedi: cb_pcimdas: remove unnecessary printk noise staging: comedi: das16m1: tidy up the irq support in das16m1_attach() staging: comedi: dmm32at: remove unnecessary printk noise staging: comedi: dmm32at: remove commented out printk debug staging: comedi: dmm32at: tidy up the irq support in dmm32at_attach() staging: comedi: dmm32at: convert a printk(KERN_ERR to a dev->err() staging: comedi: dt2801: remove disabled code in dt2801_writedata staging: comedi: dt2801: remove commented out printk() staging: comedi: dt2801: convert printk() messages to dev_dbg() staging: comedi: dt2811: remove disabled dt2811_adtrig() function staging: comedi: dt2811: remove disabled interrupt support code staging: comedi: dt2814: remove unnecessary printk noise staging: comedi: dt2814: remove bad printk noise staging: comedi: dt2814: convert a printk(KERN_ERR into a dev_err() staging: comedi: dt2814: tidy up the irq support in dt2814_attach() staging: comedi: dt2815: convert printk's in dt2815_ao_insn() staging: comedi: dt2815: convert printk's in dt2815_attach() staging: comedi: dt282x: tidy up the irq support in dt282x_attach() staging: comedi: dt282x: remove attach noise in dt282x_grab_dma() staging: comedi: dt282x: convert printk() in dt282x_attach to a dev_err() staging: comedi: dt282x: remove unnecessary blank line message staging: comedi: dt282x: remove disable code that disables the irq staging: comedi: dt282x: convert dt282x_ao_dma_interrupt() messages staging: comedi: dt282x: convert dt282x_ai_dma_interrupt() messages staging: comedi: dt282x: convert dt282x_ao_inttrig() messages staging: comedi: dt282x: remove commented out printk staging: comedi: mpc624: remove commented out printk staging: comedi: mpc624: remove unnecessary test staging: comedi: mpc624: remove unnecessary printk noise staging: comedi: mpc624: convert printk messages in mpc624_ai_rinsn() staging: comedi: rtd520: remove commented out printk debug staging: comedi: plx9080.h: remove unnecessary printk noise staging: comedi: pcm3724: remove commented out printk debug staging: comedi: pcl818: remove commented out printk debug staging: comedi: pcl818: remove printk function trace messages staging: comedi: pcl818: remove board attach noise staging: comedi: pcl818: tidy up the irq support in pcl818_attach() staging: comedi: pcl818: convert printk() messages to dev_{level} staging: comedi: pcl816: remove commented out outb() macro staging: comedi: pcl816: remove TRIG_WAKE_EOS support stub staging: comedi: pcl816: tidy up the irq support in pcl816_attach() staging: comedi: pcl816: remove commented out printk debug staging: comedi: pcl816: convert printk messages in pcl816_attach() staging: comedi: pcl812: tidy up the irq support in pcl812_attach() staging: comedi: pcl812: convert printk messages in pcl812_attach() staging: comedi: ni_tio: remove commented out printk message staging: comedi: ni_pcimio: convert printk() to dev_dbg() staging: comedi: ni_atmio16d: remove printk() noise in atmio16d_ai_insn_read() staging: comedi: ni_atmio16d: tidy up the irq support in atmio16d_attach() staging: comedi: ni_atmio16d: remove an unnecessary printk drivers/staging/comedi/drivers/adq12b.c | 2 - drivers/staging/comedi/drivers/adv_pci1710.c | 27 +++--- drivers/staging/comedi/drivers/c6xdigio.c | 45 ---------- drivers/staging/comedi/drivers/cb_pcimdas.c | 14 +--- drivers/staging/comedi/drivers/das16m1.c | 78 ++++++----------- drivers/staging/comedi/drivers/dmm32at.c | 62 +++++--------- drivers/staging/comedi/drivers/dt2801.c | 28 +++---- drivers/staging/comedi/drivers/dt2811.c | 101 +--------------------- drivers/staging/comedi/drivers/dt2814.c | 40 ++++----- drivers/staging/comedi/drivers/dt2815.c | 19 +++-- drivers/staging/comedi/drivers/dt282x.c | 120 +++++++++------------------ drivers/staging/comedi/drivers/mpc624.c | 19 ++--- drivers/staging/comedi/drivers/ni_atmio16d.c | 42 ++++------ drivers/staging/comedi/drivers/ni_pcimio.c | 6 +- drivers/staging/comedi/drivers/ni_tio.c | 1 - drivers/staging/comedi/drivers/pcl812.c | 71 ++++------------ drivers/staging/comedi/drivers/pcl816.c | 94 ++++++--------------- drivers/staging/comedi/drivers/pcl818.c | 104 ++++++++--------------- drivers/staging/comedi/drivers/pcm3724.c | 6 -- drivers/staging/comedi/drivers/pcmmio.c | 5 +- drivers/staging/comedi/drivers/plx9080.h | 13 +-- drivers/staging/comedi/drivers/rtd520.c | 3 - 22 files changed, 246 insertions(+), 654 deletions(-)
Nice clean-up. Also, I see you've got to grips with git send-email! Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel