Re: [PATCH 1/3] staging: et131x: simplify rx dma code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
> @@ -2208,8 +2204,11 @@ static int et131x_rx_dma_memory_alloc(struct et131x_adapter *adapter)
>  	rx_ring = &adapter->rx_ring;
>  
>  	/* Alloc memory for the lookup table */
> -	rx_ring->fbr[0] = kmalloc(sizeof(struct fbr_lookup), GFP_KERNEL);
> -	rx_ring->fbr[1] = kmalloc(sizeof(struct fbr_lookup), GFP_KERNEL);
> +	rx_ring->fbr[0] = kmalloc(sizeof(struct fbr_lookup) * 2, GFP_KERNEL);
> +	if (!rx_ring->fbr[0])
> +		return -ENOMEM;
> +
> +	rx_ring->fbr[1] = rx_ring->fbr[0] + 1;
>  
>  	/* The first thing we will do is configure the sizes of the buffer
>  	 * rings. These will change based on jumbo packet support.  Larger

I can't make myself review any further beyond this point...  Please
don't do this nonsense.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux