This is a series of cleanups to the DWC2 driver, in response to Dan Carpenter's review on 11/15/2013. I believe I have addressed all of Dan's suggestions, except for removing the validation checks from the dwc2_set_param_* functions. We depend on the validation checks for setting a default value for each of the parameters, so the checks cannot simply be removed. Paul Zimmerman (8): staging: dwc2: fix some functions to return a proper error code staging: dwc2: fix potential use after free staging: dwc2: rename DWC2_PARAM_TEST to DWC2_OUT_OF_BOUNDS staging: dwc2: make all the dwc2_set_param* functions void staging: dwc2: remove use of NO_FS_PHY_HW_CHECKS macro staging: dwc2: remove useless cast staging: dwc2: rename dwc2_check_core_status() staging: dwc2: remove #ifdef DEBUG from a couple of places drivers/staging/dwc2/core.c | 251 ++++++++++++--------------------------- drivers/staging/dwc2/core.h | 62 +++++----- drivers/staging/dwc2/core_intr.c | 10 +- drivers/staging/dwc2/hcd.c | 6 +- drivers/staging/dwc2/hcd.h | 4 +- drivers/staging/dwc2/hcd_ddma.c | 4 +- drivers/staging/dwc2/hcd_intr.c | 4 +- drivers/staging/dwc2/hcd_queue.c | 8 +- 8 files changed, 120 insertions(+), 229 deletions(-) -- 1.8.5.rc3 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
