Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 19, 2013 at 08:56:59PM -0500, Josh Boyer wrote:
> On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote:
> > On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote:
> > > commit b8d181e408af (staging: drm/imx: add drm plane support) added a file
> > > to the make target for DRM_IMX_IPUV3 but didn't adjust the objs required
> > > to actually build that as a module.  Kbuild got confused and this lead to
> > > link errors like:
> > > 
> > > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
> > > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
> > > 
> > > Additionally, it added a call to imx_drm_crtc_id which also fails with a
> > > link error as above.  To fix this, we adjust the make target with the proper
> > > objs, which will change the name of the resulting .ko.  We also add an
> > > EXPORT_SYMBOL_GPL for imx_drm_crtc_id.
> > > 
> > > Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
> > 
> > 
> > Acked-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > 
> > Sascha
> 
> Thanks.  So who picks this fix up?  Greg, is that you?

Yes, I will once 3.13-rc1 is out.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux