> I'm trying to merge the common code into a single function > rtl8411_init_params(), but different chips may use a different > rtlxxx_pcr_ops even they have much the same. This is because the > ops may be called frequently. So to save confusion I've sent a patch-set with you CC'ed. If you can test the patchset on your h/w and add your Tested-by: tag I will add it to each of the patches. With regards to the 'mfd: rtsx: Add rtl8402 card reader' patch, I believe you are the rightful author of that patch, so if you can send me your Signed-off-by: for that one, I will add that and make you the author. > Yet I'm trying to use Regulator Framework, it will make a > somewhat big change , and I will add it in a later time. Yes that's fine. Base any new patches on top of this patch-set. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel