Hello Ian Abbott,
The patch 5fd4b711be48: "staging: comedi: s626: sample types are
unsigned" from Oct 16, 2013, leads to the following
static checker warning: "drivers/staging/comedi/drivers/s626.c:508
s626_set_dac()
warn: impossible condition '(dacdata < 0) => (0-65535 < 0)'"
drivers/staging/comedi/drivers/s626.c
496 static void s626_set_dac(struct comedi_device *dev, uint16_t chan,
497 unsigned short dacdata)
498 {
499 struct s626_private *devpriv = dev->private;
500 uint16_t signmask;
501 uint32_t ws_image;
502 uint32_t val;
503
504 /*
505 * Adjust DAC data polarity and set up Polarity Control Register image.
506 */
507 signmask = 1 << chan;
508 if (dacdata < 0) {
^^^^^^^^^^^
This condition is no longer possible.
509 dacdata = -dacdata;
510 devpriv->dacpol |= signmask;
511 } else {
512 devpriv->dacpol &= ~signmask;
513 }
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
