On Thursday 31 October 2013 11:18:06 Mauro Carvalho Chehab wrote: > Em Thu, 17 Oct 2013 17:02:02 +0200 > > Denis Carikli <denis@xxxxxxxxxx> escreveu: > > That new macro is needed by the imx_drm staging driver > > > > for supporting the QVGA display of the eukrea-cpuimx51 board. > > > > Cc: Rob Herring <rob.herring@xxxxxxxxxxx> > > Cc: Pawel Moll <pawel.moll@xxxxxxx> > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > Cc: Stephen Warren <swarren@xxxxxxxxxxxxx> > > Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Cc: driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx > > Cc: David Airlie <airlied@xxxxxxxx> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Cc: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> > > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Cc: linux-media@xxxxxxxxxxxxxxx > > Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx> > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > Cc: Eric Bénard <eric@xxxxxxxxxx> > > Signed-off-by: Denis Carikli <denis@xxxxxxxxxx> > > It seems better to apply this one together with the other DRM patches via > DRM tree. So: > Acked-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> Actually, if I might, I'd like to nak this patch, as adding new pixel formats requires updating the documentation as well (see Documentation/DocBook/media/v4l/pixfmt*.xml). > > --- > > > > include/uapi/linux/videodev2.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/uapi/linux/videodev2.h > > b/include/uapi/linux/videodev2.h index 437f1b0..e8ff410 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -294,6 +294,7 @@ struct v4l2_pix_format { > > > > #define V4L2_PIX_FMT_RGB555X v4l2_fourcc('R', 'G', 'B', 'Q') /* 16 > > RGB-5-5-5 BE */ #define V4L2_PIX_FMT_RGB565X v4l2_fourcc('R', 'G', 'B', > > 'R') /* 16 RGB-5-6-5 BE */ #define V4L2_PIX_FMT_BGR666 > > v4l2_fourcc('B', 'G', 'R', 'H') /* 18 BGR-6-6-6 */> > > +#define V4L2_PIX_FMT_RGB666 v4l2_fourcc('R', 'G', 'B', 'H') /* 18 > > RGB-6-6-6 */> > > #define V4L2_PIX_FMT_BGR24 v4l2_fourcc('B', 'G', 'R', '3') /* 24 > > BGR-8-8-8 */ #define V4L2_PIX_FMT_RGB24 v4l2_fourcc('R', 'G', 'B', > > '3') /* 24 RGB-8-8-8 */ #define V4L2_PIX_FMT_BGR32 > > v4l2_fourcc('B', 'G', 'R', '4') /* 32 BGR-8-8-8-8 */ -- Regards, Laurent Pinchart _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel