On Wed, Oct 30, 2013 at 11:15:51AM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > > In case of error, the function platform_device_register_data() returns > ERR_PTR() and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> Acked-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > --- > drivers/staging/imx-drm/ipu-v3/ipu-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx-drm/ipu-v3/ipu-common.c > index 77a0c65..36afc48 100644 > --- a/drivers/staging/imx-drm/ipu-v3/ipu-common.c > +++ b/drivers/staging/imx-drm/ipu-v3/ipu-common.c > @@ -1006,7 +1006,7 @@ static int ipu_add_subdevice_pdata(struct device *dev, > pdev = platform_device_register_data(dev, reg->name, ipu_client_id++, > ®->pdata, sizeof(struct ipu_platform_reg)); > > - return pdev ? 0 : -EINVAL; > + return PTR_ERR_OR_ZERO(pdev); > } > > static int ipu_add_client_devices(struct ipu_soc *ipu) > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
