On 10/31/2013 07:15 AM, Chen Gang wrote: > For some architectures (e.g. arc, openrisc), BASE_BAUD isn't constant > And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use > SERIAL_PORT_DFNS to initialize static variables, statically. > > So need define SERIAL_PORT_DFNS as empty to tell drivers they don't > support SERIAL_PORT_DFNS (mostly like frv and parisc did), or can not > pass compiling > > The related error (allmodconfig for arc with gcc-4.8.0): > > CC [M] drivers/staging/speakup/serialio.o > drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant > SERIAL_PORT_DFNS > ^ > drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[0].baud_base') > drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant > drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[1].baud_base') > drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant > drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[2].baud_base') > drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant > drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[3].baud_base') > > > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> NAK - as mentioned in prev email please fix the driver. -Vineet _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel