Hey Rashika, And please Cc LKML in next. Thanks! On Fri, Oct 25, 2013 at 7:13 PM, Minchan Kim <minchan@xxxxxxxxxx> wrote: > On Tue, Oct 22, 2013 at 07:04:37PM +0530, Rashika Kheria wrote: >> As suggested by Jerome Marchand "The code in reset_store get the block device >> (bdget_disk()) but it does not put it (bdput()) when it's done using it. >> The usage count is therefor incremented but never decremented." >> >> Hence, this patch introduces a call to bdput() to decrement the variable after usage. >> >> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx> >> --- >> drivers/staging/zram/zram_drv.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c >> index 8679a06..2cb33ab 100644 >> --- a/drivers/staging/zram/zram_drv.c >> +++ b/drivers/staging/zram/zram_drv.c >> @@ -664,6 +664,7 @@ static ssize_t reset_store(struct device *dev, >> >> /* Make sure all pending I/O is finished */ >> fsync_bdev(bdev); >> + bdput(bdev); > > We should handle error case, too. > And please put this bug fix patch ahead of [1/2] because this patch is > more real bug fix than [1/2] which is just warning of smatch. > > Thanks. > > -- > Kind regards, > Minchan Kim -- Kind regards, Minchan Kim _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
