On Sat, Oct 19, 2013 at 01:02:25AM +0300, Eli Billauer wrote: > This is necessary so that xillybus_core uses the correct device pointer > for PCIe devices in diagnostic message calls (dev_err, dev_warn and dev_info) > The changelog is unclear what happens in the current code. Does it use a different incorrect pointer? Does it NULL dereference? I looked briefly at the code (20 seconds) and it doesn't seem to use dev_err(), it still uses pr_err(). So maybe this change is preparation for future work? What I'm saying is that these are questions the changelog should answer. (Don't bother resending the patch, the changelog is good enough from a newbie for staging but if you could just answer on the thread that's ok). regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
