On Sat, Oct 19, 2013 at 08:28:21AM -0700, Lisa Nguyen wrote:
> Fix cfs_bitmap_t struct and function parameters to eliminate the
> "Do not add new typedefs" warning generated by checkpatch.pl and
> meet kernel coding style.
>
> Signed-off-by: Lisa Nguyen <lisa@xxxxxxxxxxxxxxx>
> ---
> .../staging/lustre/include/linux/libcfs/bitmap.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/linux/libcfs/bitmap.h b/drivers/staging/lustre/include/linux/libcfs/bitmap.h
> index f3d4a89..d1538b0 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/bitmap.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/bitmap.h
> @@ -37,18 +37,18 @@
> #define _LIBCFS_BITMAP_H_
>
>
> -typedef struct {
> +struct cfs_bitmap_t {
You don't need the "_t" here anymore, it should just be "struct
cfs_bitmap".
"_t" is a Windows-ism, no need for that in Linux :)
Care to redo this patch that way?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
