On Thu, Oct 17, 2013 at 05:02:12PM +0200, Denis Carikli wrote: > + if (imxpd->lcd_reg) > + if (regulator_enable(imxpd->lcd_reg)) > + dev_err(imxpd->dev, "Failed to enable lcd regulator.\n"); > + In staging the style is to use braces around multi-line indents for readability. Or you could do: if (imxpd->lcd_reg && regulator_enable(imxpd->lcd_reg)) dev_err(imxpd->dev, "Failed to enable lcd regulator.\n"); These kind of tiny things aren't worth resending, but for next time. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel