On Thu, Oct 17, 2013 at 12:54:52AM +0530, Dhanunjaya Naidu Ravada wrote: > From: Dhanunjaya <dhanunjaya.matrix@xxxxxxxxx> Again, doesn't match the signed-off-by: or From: line on your email :( > This is a patch to the ni_660x.c file that fixes up a semicolon warning > found by the checkpatch.pl tool. No it isn't, it also does something else in this file. > > Signed-off-by: Dhanunjaya Naidu Ravada <dhanunjaya.matrix@xxxxxxxxx> > --- > drivers/staging/comedi/drivers/ni_660x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c > index 3607336..95bb432 100644 > --- a/drivers/staging/comedi/drivers/ni_660x.c > +++ b/drivers/staging/comedi/drivers/ni_660x.c > @@ -28,7 +28,7 @@ > * > * Encoders work. PulseGeneration (both single pulse and pulse train) > * works. Buffered commands work for input but not output. > - * > + * That doesn't look like a semicolon fix. > * References: > * DAQ 660x Register-Level Programmer Manual (NI 370505A-01) > * DAQ 6601/6602 User Manual (NI 322137B-01) > @@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev, > s->type = COMEDI_SUBD_COUNTER; > s->subdev_flags = > SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL | > - SDF_CMD_READ /* | SDF_CMD_WRITE */ ; > + SDF_CMD_READ; /* | SDF_CMD_WRITE */ Nope, please leave the original code, it's correct. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
