On Mon, Oct 14, 2013 at 10:16:49PM +0300, Dan Carpenter wrote: > On Mon, Oct 14, 2013 at 09:39:06PM +0300, Aaro Koskinen wrote: > > It's initialized in cvm_oct_phy_setup_device(): > > > > priv->phydev = of_phy_connect(dev, phy_node, cvm_oct_adjust_link, 0, > ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ > > Sorry I should have explained better. > > We use cvm_oct_adjust_link() to initialize priv->phydev but > cvm_oct_adjust_link() depends on priv->phydev. It seems like we would > hit the NULL dereference every time. Weird huh? It doesn't happen on my system (EdgeRouter Lite). I think you need to explain even more better. :-) What you mean by "We use cvm_oct_adjust_link() to initialize priv->phydev..."? Sorry, maybe I'm just missing something really obvious... A. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel