[PATCHv2] staging: octeon-ethernet: trivial: Avoid OOPS if phydev is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sorry. Haven't signed off for a while now :(

I bet that this is really an issue of incorrect OF information. If I find out more I'll let you know.

@dan: The code works for some interfaces - so phydev is set correctly in some cases.

Signed-off-by: Sebastian Poehn <sebastian.poehn@xxxxxxxxxxxxxx>
---
diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
index 83b1030..bc8c503 100644
--- a/drivers/staging/octeon/ethernet-mdio.c
+++ b/drivers/staging/octeon/ethernet-mdio.c
@@ -121,6 +121,9 @@ static void cvm_oct_adjust_link(struct net_device *dev)
 	struct octeon_ethernet *priv = netdev_priv(dev);
 	cvmx_helper_link_info_t link_info;
 
+	if (!priv->phydev)
+		return;
+
 	if (priv->last_link != priv->phydev->link) {
 		priv->last_link = priv->phydev->link;
 		link_info.u64 = 0;

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux