On 2013-10-09 23:47, Hartley Sweeten wrote:
On Tuesday, October 08, 2013 11:06 AM, Ian Abbott wrote:
Tidy up the "s626.h" header file a bit, cleaning up the whitespace and
fixing overlength lines. Add multiple inclusion protection (even though
it's only included once and only by "s626.c"). Remove unnecessary
driver comment near the start of the file as it is more or less the same
as the one in "s626.c". Remove obviously unused/useless stuff.
I'm not sure what to do about the INTEL/MOTOROLA platform selection in
the file. I've left it alone (set to INTEL) for now.
Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
---
drivers/staging/comedi/drivers/s626.h | 925 ++++++++++++++++------------------
1 file changed, 436 insertions(+), 489 deletions(-)
Ian,
I'm still reviewing this series but I had a comment on the s626.h file.
Since the s626 driver is the only user of this header it would be nicer
if this head just went away. Any objections to just merging its contents
directly info to s626.c file? This could be done as a single patch after
this series is applied.
Possibly, but it's quite long and boring - just a load of register
definitions.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
