Re: [PATCH 03/15] staging: rtl8192u: fix line size in r819xU_cmdpkt.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 10, 2013 at 10:43:49AM +0300, Xenia Ragiadakou wrote:
> This patch reduces the line length below 80 chars to improve code readability.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
>  drivers/staging/rtl8192u/r819xU_cmdpkt.h | 28 +++++++++++++++-------------
>  1 file changed, 15 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h b/drivers/staging/rtl8192u/r819xU_cmdpkt.h
> index 09030fd..2e079c7 100644
> --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
> +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.h
> @@ -1,17 +1,17 @@
>  #ifndef R819XUSB_CMDPKT_H
>  #define R819XUSB_CMDPKT_H
>  /* Different command packet have dedicated message length and definition. */
> -#define		CMPK_RX_TX_FB_SIZE					sizeof(cmpk_txfb_t)		//20
> -#define		CMPK_TX_SET_CONFIG_SIZE				sizeof(cmpk_set_cfg_t)	//16
> -#define		CMPK_BOTH_QUERY_CONFIG_SIZE			sizeof(cmpk_set_cfg_t)	//16
> -#define		CMPK_RX_TX_STS_SIZE					sizeof(cmpk_tx_status_t)//
> -#define		CMPK_RX_DBG_MSG_SIZE			sizeof(cmpk_rx_dbginfo_t)//
> -#define		CMPK_TX_RAHIS_SIZE			sizeof(cmpk_tx_rahis_t)
> +#define		CMPK_RX_TX_FB_SIZE		sizeof(cmpk_txfb_t)	//20
> +#define		CMPK_TX_SET_CONFIG_SIZE		sizeof(cmpk_set_cfg_t)	//16
> +#define		CMPK_BOTH_QUERY_CONFIG_SIZE	sizeof(cmpk_set_cfg_t)	//16
> +#define		CMPK_RX_TX_STS_SIZE		sizeof(cmpk_tx_status_t)//
> +#define		CMPK_RX_DBG_MSG_SIZE		sizeof(cmpk_rx_dbginfo_t)//
> +#define		CMPK_TX_RAHIS_SIZE		sizeof(cmpk_tx_rahis_t)

This is fine (don't resend) but next time feel free to just remove the
big gap after the #define as well.

#define CMPK_RX_TX_FB_SIZE	sizeof(cmpk_txfb_t)

In the end, we will probably just get rid of all these defines anyway
and use sizeof() directly.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux