Re: [PATCH v4 1/2] staging: dgap: tty.c: adds error handing in tty driver allocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 3, 2013 at 1:23 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Oct 01, 2013 at 12:54:20PM -0400, Lidza Louina wrote:
>> +     return 0;
>> +
>> +err_unregister_serial:
>> +        tty_unregister_driver(brd->SerialDriver);
>> +err_free_print_ttys:
>> +        kfree(brd->PrintDriver->ttys);
>> +err_put_tty_print:
>> +        put_tty_driver(brd->PrintDriver);
>> +err_free_serial_ttys:
>> +        kfree(brd->SerialDriver->ttys);
>> +err_put_tty_serial:
>> +        put_tty_driver(brd->SerialDriver);
>>       return (rc);
>
> You forgot to run this patch through checkpatch.pl :(
>
> This series has been a major pain, why not set it aside for a few days
> and do something easier before picking it up and trying it again?
>
> thanks,
>
> greg "I need a vacation too" k-h

Alrighty.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux