On Tue, 2013-10-01 at 21:57 -0400, Mathieu Rhéaume wrote:
> This patch changes seq_printf for seq_puts in binder.c.
> It fixes the warnings emitted by checkpatch.pl.
Please realign function argument to the open parenthesis.
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -3272,7 +3272,7 @@ binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer)
> static void print_binder_transaction(struct seq_file *m, const char *prefix,
> struct binder_transaction *t)
> {
> - seq_printf(m,
> + seq_puts(m,
> "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",
> prefix, t->debug_id, t,
> t->from ? t->from->proc->pid : 0,
This should be
seq_puts(m, "%s..."
prefix, etc...
using two tabs then 1 space to align to open parenthesis
> @@ -3287,7 +3287,7 @@ static void print_binder_transaction(struct seq_file *m, const char *prefix,
> if (t->buffer->target_node)
> seq_printf(m, " node %d",
> t->buffer->target_node->debug_id);
> - seq_printf(m, " size %zd:%zd data %p\n",
> + seq_puts(m, " size %zd:%zd data %p\n",
> t->buffer->data_size, t->buffer->offsets_size,
seq_puts(m, " size...",
t->buffer->etc...
etc...
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
