On 2013-10-01 23:07, H Hartley Sweeten wrote:
Cleanup another comedi driver.
H Hartley Sweeten (22):
staging: comedi: ni_6527: remove DRIVER_NAME define
staging: comedi: ni_6527: remove unused NI6527_*_SIZE defines
staging: comedi: ni_6527: remove unused DEBUG* defines
staging: comedi: ni_6527: remove extra probe noise
staging: comedi: ni_6527: factor out the code that sets the filter interval
staging: comedi: ni_6527: factor out the code that sets the filter enables
staging: comedi: ni_6527: tidy up ni6527_di_insn_config()
staging: comedi: ni_6527: tidy up ni6527_{di,do}_insn_bits()
staging: comedi: ni_6527: use dev->read_subdev in interrupt handler
staging: comedi: ni_6527: tidy up ni6527_interrupt()
staging: comedi: ni_6527: rename CamelCase defines for the clear register
staging: comedi: ni_6527: rename CamelCase defines for the control register
staging: comedi: ni_6527: tidy up ni6527_intr_cmd()
staging: comedi: ni_6527: tidy up ni6527_intr_cancel()
staging: comedi: ni_6527: tidy up ni6527_intr_insn_config()
staging: comedi: ni_6527: remove COMEDI_MITE dependancy
staging: comedi: ni_6527: introduce ni6527_reset()
staging: comedi: ni_6527: tidy up the interrupt subdevice
staging: comedi: ni_6527: tidy up ni6527_auto_attach()
staging: comedi: ni_6527: tidy up the comedi_driver declaration
staging: comedi: ni_6527: tidy up multi-line comments
staging: comedi: ni_6527: change MODULE_DESCRIPTION
drivers/staging/comedi/Kconfig | 2 -
drivers/staging/comedi/drivers/ni_6527.c | 457 ++++++++++++++++---------------
2 files changed, 239 insertions(+), 220 deletions(-)
Looks good. It could possibly do with an additional safety check in the
interrupt routine to make damn sure it cannot access the subdevice
before it is set up, rather than relying completely on the value read
from the hardware's interrupt status register.
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
