On Wed, 2013-10-02 at 15:15 +1000, Ryan Mallon wrote: > On 02/10/13 11:57, Mathieu Rhéaume wrote: > > This patch changes seq_printf for seq_puts in binder.c. > > It fixes the warnings emitted by checkpatch.pl. [] > Umm, this won't compile. seq_puts() is defined as: > > int seq_puts(struct seq_file *m, const char *s); > > checkpatch.pl does indeed complain about uses of seq_printf() in > drivers/staging/android/binder.c which are passing formatted strings. At > a quick glance it looks like checkpatch.pl is only checking for the > format string on the same line as seq_printf(), so this files ugly > coding style confuses the check. Joe? True. This patch should have fixed it. It's in -next already. https://lkml.org/lkml/2013/9/13/698 > Anyway, please don't blindly change things in the kernel without at > least compile testing them. Yes, please. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
