On Fri, Sep 27, 2013 at 07:11:47AM -0400, Lidza Louina wrote: > On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: > > This check is not required. > > > > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> > > Cc: Lidza Louina <lidza.louina@xxxxxxxxx> > > --- > > drivers/staging/dgnc/dgnc_kcompat.h | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/staging/dgnc/dgnc_kcompat.h b/drivers/staging/dgnc/dgnc_kcompat.h > > index ed85152..eaec7e6 100644 > > --- a/drivers/staging/dgnc/dgnc_kcompat.h > > +++ b/drivers/staging/dgnc/dgnc_kcompat.h > > @@ -28,11 +28,6 @@ > > #ifndef __DGNC_KCOMPAT_H > > #define __DGNC_KCOMPAT_H > > > > -# ifndef KERNEL_VERSION > > -# define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c)) > > -# endif > > - > > - > > #if !defined(TTY_FLIPBUF_SIZE) > > # define TTY_FLIPBUF_SIZE 512 > > #endif > > -- > > 1.7.9.5 > > > > This looks great. Thanks. :) So, is that your "implied" ack? :) In the future, for patches you review and want me to apply, you can say: Acked-by: Yourname <email> or, even better, as you are the maintainer, and I should be getting your signed off for all patches for the driver: Signed-off-by: Yourname <email> I'll just take this one for am implied ack for now, but in the future, it would be good to have an explicit one :) thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
