Hi Dan, On Tue, 2013-10-01 at 01:25 +0300, Dan Carpenter wrote: > On Mon, Sep 30, 2013 at 05:05:23PM -0500, dinguyen@xxxxxxxxxx wrote: > > From: Dinh Nguyen <dinguyen@xxxxxxxxxx> > > > > The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding > > a 1 to a 0xf results in a 0 for host_channels. Thus, the driver was always > > thinking it had 0 host channels. > > > > Represent the correct number of host channels by using the host_channels > > variable of dwc2_core_params struct. We should do the +1 in > > dwc2_set_param_host_channels(); > > > > Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx> > > Ah. Good. You've fixed the compile problem, but I still don't think > you have tested it; there just wasn't enough time. I did test the patch. The driver was not able to even enumerate any devices, with this patch it now works. Dinh > > regards, > dan carpenter > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
