Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Sep 30, 2013 at 12:41:59PM -0700, David Daney wrote:
> On 09/30/2013 12:35 PM, Aaro Koskinen wrote:
> >No, the original logic was already broken. The code assumed that the
> >NAPI scheduled by the driver init gets executed always on CPU 0. The
> >IRQ got enabled just because we are lucky.
> 
> No.  The default affinity for all irqs is CPU0 for just this reason.
> So there was no luck involved.

According the Kconfig, this driver can be compiled as a module:

> config OCTEON_ETHERNET
>	tristate "Cavium Networks Octeon Ethernet support"
[...]
>	To compile this driver as a module, choose M here.  The module
>	will be called octeon-ethernet.

What guarantees that CPU0 is around (or the smp_affinity is at its
default value) by the time user executes modprobe?

A.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux