On Fri, 27 Sep 2013, Dan Carpenter wrote:
> It looks like magicmouse_raw_event() returns 1 on success and 0 on
> failure.
Good catch indeed.
I am not completely sure whether we are going to fix an oops or not by
this, as I haven't seen the actual oops anywhere in this thread :) But
definitely this looks like a good fix.
Joseph, could you please test with that? Thanks.
diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index 3b43d1c..c211eb9 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -334,7 +334,7 @@ static int magicmouse_raw_event(struct hid_device *hdev,
size - 2 - data[1]);
break;
default:
- return 0;
+ return 1;
}
if (input->id.product == USB_DEVICE_ID_APPLE_MAGICMOUSE) {
@@ -347,7 +347,7 @@ static int magicmouse_raw_event(struct hid_device *hdev,
}
input_sync(input);
- return 1;
+ return 0;
}
static int magicmouse_setup_input(struct input_dev *input, struct hid_device *hdev)
--
Jiri Kosina
SUSE Labs
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
