Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
>  
>  			/* init SEQ register SR30 - SR75 */
>  			for (i = 0; i < SIZE_SR30_SR75; i++)
> -				if (((i + 0x30) != 0x62) \
> -					&& ((i + 0x30) != 0x6a) \
> -					&& ((i + 0x30) != 0x6b))
> +				if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> +							&& ((i + 0x30) != 0x6b))

The prefered way would be to align this like this:

				if ((i + 0x30) != 0x62 &&
				    (i + 0x30) != 0x6a &&
				    (i + 0x30) != 0x6b)

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux