Greg, I am currently travelling; when I get back I will take a look. K. Y > -----Original Message----- > From: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday, September 26, 2013 9:00 AM > To: KY Srinivasan > Cc: Haiyang Zhang; devel@xxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 00/13] hv: clean up dev_attr usage > > On Tue, Sep 17, 2013 at 06:42:30PM +0000, KY Srinivasan wrote: > > > > > > > -----Original Message----- > > > From: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > > Sent: Friday, September 13, 2013 11:33 AM > > > To: KY Srinivasan; Haiyang Zhang > > > Cc: devel@xxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > > Subject: [PATCH 00/13] hv: clean up dev_attr usage > > > > > > Hi, > > > > > > Here's a set of 13 patches to get rid of the dev_attrs use in the hv bus > > > code, as it will be going away soon. It's _way_ bigger than all other > > > conversions I've had to do so far in the kernel, as you were using a > > > "multiplexor" function for all of these files. > > > > > > So, I've broken it up into individual show/store sysfs functions, and > > > cleaned up a bunch of debug structures that aren't needed and shouldn't > > > be exported to the rest of the kernel. > > > > > > I've also fixed up some void * usage in the hv core, in patch 07, to > > > make things simpler and not so "magic" when dealing with these pages. > > > If you could review that one closely to ensure I didn't mess anything > > > up, I would appreciate it. > > > > > > Also, are all of these files really needed for sysfs? They seem to be > > > all debugging stuff, shouldn't they go into debugfs if you really > > > need/use them anymore? > > > > > > KY, could you test these out? I don't have access to a hv system at the > > > moment. I'll wait for your ack before applying them to any of my trees. > > > > The patches look good and I tested them. The guest comes up and is functional. > > I did notice though that the pending state appears to be a signed entity now > which was not the > > the case before - I see a negative sign when I cat the client/server pending > state. > > Which exact file is that? I didn't change the % modifiers for any of > the data types, or at least I sure shouldn't have, if so, that's a bug > on my side. > > Thanks for testing, I'll queue these up, and if you can tell me which > sysfs file is different, I'll verify the code conversion again, but I > just reviewed it and can't seem to find anything. > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
