Re: [PATCH v2 3/5] staging: dgap: tty.c: removes smatch warnings "redundant null check"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 25, 2013 at 07:08:52PM -0400, Lidza Louina wrote:
> This patch removes these smatch warnings:
> redundant null check on dgap_TmpWriteBuf calling kfree()
> redundant null check on brd->SerialDriver->ttys calling kfree()
> redundant null check on brd->PrintDriver->ttys calling kfree()
> 
> The code checked to see if these variables are null
> before freeing. This check isn't needed.
> 
> Signed-off-by: Lidza Louina <lidza.louina@xxxxxxxxx>
> ---
>  drivers/staging/dgap/dgap_tty.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)

And I've applied this one too.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux