On Wed, Sep 25, 2013 at 04:02:44PM -0700, Greg Kroah-Hartman wrote: > On Sat, Aug 31, 2013 at 03:56:06PM -0700, Guenter Roeck wrote: > > Use device_create_with_groups to create sysfs attributes together with device. > > Also create class attribute together with class registration. > > This simplifies the code and ensures that attribute files exist when udev > > events are generated. > > > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > --- > > I suspect that the 'register_with_sysfs' attribute exists to work around > > the problem solved with this patch. It doesn't make much sense otherwise. > > Can it be removed ? > > All of these sysfs files can be removed, they shouldn't be there, as it > looks like they are used for odd configuration things. > > And a single tty driver shouldn't be a "class" at all. > > sorry, > No need to be sorry - not my driver, nor am I using it ;). I am perfectly fine with you dropping this patch. Guenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
