On Mon, Sep 23, 2013 at 06:47:13PM -0400, Lidza Louina wrote: > This patch removes this smatch warning: > warn: missing break? reassigning 'ch->pscan_state' I would just leave this one as is. With Smatch, I don't put a lot of effort into cutting down false positives. Eventually I do plan to parse the file and grep for "fall" on the lines before the case statement. That will silence most of the missing break false positives. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel