On Sat, Sep 21, 2013 at 08:55:31PM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 20, 2013 at 04:42:08PM +0100, Ben Hutchings wrote:
> > On Thu, 2013-09-19 at 22:43 +0100, Russell King wrote:
> > > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) ||
> > > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) {
> >
> > Surely we want && here.
>
> Good catch, exactly right. Thanks for the review, here's the replacement
> patch:
>
> 8<====
> From: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> Subject: [PATCH] DMA-API: staging: et131x: replace
> dma_set_mask()+dma_set_coherent_mask() with new helper
>
> Replace the following sequence:
>
> dma_set_mask(dev, mask);
> dma_set_coherent_mask(dev, mask);
>
> with a call to the new helper dma_set_mask_and_coherent().
>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> ---
> drivers/staging/et131x/et131x.c | 17 ++---------------
> 1 files changed, 2 insertions(+), 15 deletions(-)
Acked-by: Mark Einon <mark.einon@xxxxxxxxx>
Cheers,
Mark
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
