Re: [PATCH 0/9] staging: comedi: adl_pci6208: cleanup driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-09-18 19:46, H Hartley Sweeten wrote:
Fix two issues with the analog output subdevice:
   1) The raw data from the comedi core should be saved for readback
      not the munged two's complement data that is written to the
      hardware.
   2) Avoid a possible deadlock while waiting to write the analog
      output data.

Introduce a comedi core helper function to handle the munging of the
offset binary data from the core into the two's complement form needed
by some hardware.

Tidy up the rest of the driver a bit.

H Hartley Sweeten (9):
   staging: comedi: adl_pci6208: save raw data for analog output readback
   staging: comedi: adl_pci6208: don't deadlock while waiting to write ao data
   staging: comedi: core: introduce comedi_offset_munge()
   staging: comedi: adl_pci6208: use comedi_offset_munge()
   staging: comedi: adl_pci6208: tidy up pci6208_ao_winsn()
   staging: comedi: adl_pci6208: tidy up pci6208_ao_rinsn()
   staging: comedi: adl_pci6208: remove board attach noise
   staging: comedi: adl_pci6208: tidy up multi-line comments
   staging: comedi: adl_pci6208: change MODULE_DESCRIPTION

  drivers/staging/comedi/comedidev.h           |   7 +-
  drivers/staging/comedi/drivers/adl_pci6208.c | 127 ++++++++++++++-------------
  2 files changed, 73 insertions(+), 61 deletions(-)

Looks good!

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux