> -----Original Message----- > From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] > Sent: Wednesday, September 18, 2013 2:01 PM > To: KY Srinivasan > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; > jasowang@xxxxxxxxxx; dan.carpenter@xxxxxxxxxx; linux- > input@xxxxxxxxxxxxxxx; vojtech@xxxxxxx > Subject: Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V > synthetic keyboard > > Hi K.Y., > > On Tue, Sep 17, 2013 at 04:26:58PM -0700, K. Y. Srinivasan wrote: > > Add a new driver to support synthetic keyboard. On the next generation > > Hyper-V guest firmware, many legacy devices will not be emulated and this > > driver will be required. > > > > I would like to thank Vojtech Pavlik <vojtech@xxxxxxx> for helping me with the > > details of the AT keyboard driver. I would also like to thank > > Dan Carpenter <dan.carpenter@xxxxxxxxxx> and > > Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> for their detailed review of > this > > driver. > > > > I have addressed all the comments of Dan and Dmitry in this version of > > the patch > > This looks much better. Could you tell me if the patch below (on top of > yours) still works? > > Thanks. Thank you. The code looks much better now. You forgot to initialize the port_data and after I fixed that everything seems to work as it did before: Here is the patch I used: > -----Original Message----- > From: K. Y. Srinivasan [mailto:kys@xxxxxxxxxxxxx] > Sent: Wednesday, September 18, 2013 4:50 PM > To: KY Srinivasan > Subject: [PATCH 1/1] Drivers: input: serio: hyper-V: Initialize the port data > correctly > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > --- > drivers/input/serio/hyperv-keyboard.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv- > keyboard.c > index 401fbdd..aff4152 100644 > --- a/drivers/input/serio/hyperv-keyboard.c > +++ b/drivers/input/serio/hyperv-keyboard.c > @@ -351,6 +351,7 @@ static int hv_kbd_probe(struct hv_device *hv_dev, > > hv_serio->dev.parent = &hv_dev->device; > hv_serio->id.type = SERIO_8042_XL; > + hv_serio->port_data = kbd_dev; > strlcpy(hv_serio->name, dev_name(&hv_dev->device), > sizeof(hv_serio->name)); > strlcpy(hv_serio->phys, dev_name(&hv_dev->device), > -- > 1.7.4.1 Once again; thank you for all your help. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
