On Wed, Sep 04, 2013 at 12:19:16PM +0300, Dan Carpenter wrote: > Sorry, this is still in my postponed messages folder. I meant to send > it earlier. > > On Mon, Sep 02, 2013 at 10:23:21PM +0100, Mark Einon wrote: > > Ignoring checkpatch for some lines - now just over 80 chars, but much > > more readable. > > > > The person who "fixed" these long lines, did it in the wrong way, yes. > But we always apply those because it's the easiest way and you can't > fight against checkpatch.pl. If we go back to long lines, we'll just > immediately apply another "break the long lines up" patch from some > newbie who doesn't know any better. > > We need to fix it in the right way instead of re-introducing checkpatch > warnings. ** Greg ** - please drop this patchset, I will re-send the other three without this one. Hi Dan, I understand your point, thanks for the review. As I've little time to make a large change at this time, I'll add an item to the TODO based on your points above. Cheers, Mark _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
