On Tue, Sep 10, 2013 at 10:44:07AM +0530, navin patidar wrote: > ret == 0 means success, anything else is failure. > Hopefully, it's only returning negative error codes. Otherwise it needs a different fix. There isn't an official kernel style on if "if (ret < 0)" is better than "if (ret)". Some subsystems have a preference but most don't care. It's up to the maintainer to choose. Your patch is fine, but the changelog is misleading. It should just say "I prefer the other style" instead of "This code is wrong and has buggy error handling". regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
