On Mon, Sep 09, 2013 at 10:08:19AM -0700, Guenter Roeck wrote: > On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote: > > On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote: > > > On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote: > > > > Can't we just export the functions for those arches? Surely lutre > > > > isn't the first/only driver that needs this? > > > > > > Lustre is. These are core mm helpers, and lustre uses them to > > > reimplement another core VM function. It then uses it to access > > > userspace environment variable. > > > > > > In short all this code should be nuked, and no new symbols should be > > > exported. > > > > Ugh, you are right, the lustre code needs to be fixed here. > > > Given that, should I send another patch marking it as BROKEN again ? Well, on those arches it's "broken", so I'll dig up your original patch on this thread. It's just "normal" for staging drivers to duplicate core code, it needs to be fixed up before it can be merged into the kernel tree, so no need to do anything special. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
