Re: [PATCH v3] mfd: rtsx: Modify rts5249_optimize_phy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



于 2013年09月10日 17:28, Lee Jones 写道:
I would like some more information in the commit log though. You're
making a lot of configuration changes here and due to the
incomprehensible 'magic numbers' used previously, it's impossible to
know what you're changing by just reading the code.

Why won't the rts**** be initialise properly and what exactly are you
changing to rectify the situation?

Hi Lee:

It's a little difficult to describe it very clearly. To put it simply, the default setting of rts5249 is not good, and it will cause the signal quality very bad. So we have to change those values to achieve a better signal quality.

Do I need amend the commit and add the above description and resend it ?

BR,
Wei
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux