Re: [PATCH v2 4/6] staging: dgnc: removes kzalloc error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 06, 2013 at 04:48:30PM -0400, Lidza Louina wrote:
> This patch removes the error messages associated
> with errors in kzalloc. The driver doesn't need to
> add the error message because kzalloc already prints
> a more useful message.
> 
> Signed-off-by: Lidza Louina <lidza.louina@xxxxxxxxx>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 2 --
>  drivers/staging/dgnc/dgnc_tty.c    | 4 ----
>  2 files changed, 6 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index 3717d86..6bc944d 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -501,7 +501,6 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
>  	brd = dgnc_Board[dgnc_NumBoards] =
>  	kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
>  	if (!brd) {
> -		APR(("memory allocation for board structure failed\n"));
>  		return -ENOMEM;
>  	}

This patch should remove the curly braces as well.  Fix it in a later
patch.  It's not worth resending just for that.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux