Re: [PATCH 2/4] [media] lirc_bt829: Fix physical address type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote:
> On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> 
> >         pci_addr_phys = pdev->resource[0].start;
> > -       dev_info(&pdev->dev, "memory at 0x%08X\n",
> > -                (unsigned int)pci_addr_phys);
> > +       dev_info(&pdev->dev, "memory at 0x%08llX\n",
> > +                (unsigned long long)pci_addr_phys);
> 
> You could use %pa instead for printing phys_addr_t:
> 
> dev_info(&pdev->dev, "memory at %pa\n", &pci_addr_phys);

Could do, but I'm not sure it's clearer.  And all these %p formats
defeat type-checking anyway.

Ben.

-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux