Re: [PATCH 00/15] staging: comedi: comedi_parport: cleanup driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-08-28 21:55, H Hartley Sweeten wrote:
Use the new comedi_dio_insn_bits() and comedi_dio_insn_config() helpers
to tidy up the digital subdevices in this driver.

Remove the need for the kzalloc'd private data.

H Hartley Sweeten (15):
   staging: comedi: comedi_parport: tidy up the register map
   staging: comedi: comedi_parport: remove 'a_data' from private data
   staging: comedi: comedi_parport: tidy up parport_insn_a()
   staging: comedi: comedi_parport: fix parport_insn_config_a()
   staging: comedi: comedi_parport: tidy up parport_insn_b()
   staging: comedi: comedi_parport: tidy up parport_insn_c()
   staging: comedi: comedi_parport: remove 'c_data' from private data
   staging: comedi: comedi_parport: remove 'enable_irq' from private data
   staging: comedi: comedi_parport: don't fail attach if irq is not available
   staging: comedi: comedi_parport: tidy up parport_attach()
   staging: comedi: comedi_parport: tidy up multi-line comments
   staging: comedi: comedi_parport: reorder #include's
   staging: comedi: comedi_parport: rename parport_intr_insn()
   staging: comedi: comedi_parport: use dev->read_subdev in interrupt handler
   staging: comedi: comedi_parport: change MODULE_DESCRIPTION

  drivers/staging/comedi/drivers/comedi_parport.c | 380 +++++++++++-------------
  1 file changed, 177 insertions(+), 203 deletions(-)

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

Looks okay, but it depends on the "staging: comedi: tidy up digital output (*insn_bits)" patch series that I had a few issues with.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux